nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-13 22:12:43 +01:00
Code Activity

fixup: document why we're not writing through stdin right now

Browse source
This commit is contained in:
Cole Helbling 2025-07-14 11:01:46 -07:00
parent 5b27325bc2
commit de158c335c
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/libstore/unix/build/external-derivation-builder.cc
View file

@ -84,8 +84,10 @@ struct ExternalDerivationBuilder : DerivationBuilderImpl
json.emplace("realStoreDir", getLocalStore(store).config->realStoreDir.get()); json.emplace("realStoreDir", getLocalStore(store).config->realStoreDir.get());
json.emplace("system", drv.platform); json.emplace("system", drv.platform);
// FIXME: maybe write this JSON into the builder's stdin instead....? // TODO(cole-h): writing this to stdin is too much effort right now, if we want to revisit
auto jsonFile = topTmpDir + "/build.json"; // that, see this comment by Eelco about how to make it not suck:
// https://github.com/DeterminateSystems/nix-src/pull/141#discussion_r2205493257
auto jsonFile = std::filesystem::path{topTmpDir} / "build.json";
writeFile(jsonFile, json.dump()); writeFile(jsonFile, json.dump());
pid = startProcess([&]() { pid = startProcess([&]() {