From deb57afda40aed54c43d27f1046b7998b19f6fcc Mon Sep 17 00:00:00 2001 From: gustavderdrache Date: Mon, 12 May 2025 18:56:59 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Graham Christensen --- doc/manual/source/release-notes-determinate/changes.md | 4 +--- doc/manual/source/release-notes-determinate/rl-3.5.2.md | 5 +++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/manual/source/release-notes-determinate/changes.md b/doc/manual/source/release-notes-determinate/changes.md index 023e506e6..757fcbbb0 100644 --- a/doc/manual/source/release-notes-determinate/changes.md +++ b/doc/manual/source/release-notes-determinate/changes.md @@ -28,6 +28,4 @@ This section lists the differences between upstream Nix 2.28 and Determinate Nix -* Fix emitting narHash in lock files when lazy trees are disabled by @edolstra in [DeterminateSystems/nix-src#63](https://github.com/DeterminateSystems/nix-src/pull/63) - -* Improve 'cannot read file from tarball' error by @edolstra in [DeterminateSystems/nix-src#64](https://github.com/DeterminateSystems/nix-src/pull/64) \ No newline at end of file +* Tell users a source is corrupted ("cannot read file from tarball: Truncated tar archive detected while reading data"), improving over the previous 'cannot read file from tarball' error by @edolstra in [DeterminateSystems/nix-src#64](https://github.com/DeterminateSystems/nix-src/pull/64) \ No newline at end of file diff --git a/doc/manual/source/release-notes-determinate/rl-3.5.2.md b/doc/manual/source/release-notes-determinate/rl-3.5.2.md index 108a270df..bc5396c25 100644 --- a/doc/manual/source/release-notes-determinate/rl-3.5.2.md +++ b/doc/manual/source/release-notes-determinate/rl-3.5.2.md @@ -3,8 +3,9 @@ * Based on [upstream Nix 2.28.3](../release-notes/rl-2.28.md). ## What's Changed -* Fix emitting narHash in lock files when lazy trees are disabled by @edolstra in [DeterminateSystems/nix-src#63](https://github.com/DeterminateSystems/nix-src/pull/63) -* Improve 'cannot read file from tarball' error by @edolstra in [DeterminateSystems/nix-src#64](https://github.com/DeterminateSystems/nix-src/pull/64) +* Fix a regression where narHash was not added to lock files when lazy trees were disabled by @edolstra in [DeterminateSystems/nix-src#63](https://github.com/DeterminateSystems/nix-src/pull/63) + +* Tell users a source is corrupted ("cannot read file from tarball: Truncated tar archive detected while reading data"), improving over the previous 'cannot read file from tarball' error by @edolstra in [DeterminateSystems/nix-src#64](https://github.com/DeterminateSystems/nix-src/pull/64) **Full Changelog**: [v3.5.1...v3.5.2](https://github.com/DeterminateSystems/nix-src/compare/v3.5.1...v3.5.2)