nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-09 12:06:01 +01:00
Code Activity

nix flake check: Remove incorrect assertion

Browse source 
The assumption that no unknown paths can be returned is incorrect. It
can happen if a derivation has outputs that are substitutable, but
that have references that cannot be substituted (i.e. an incomplete
closure in the binary cache). This can easily happen with
magic-nix-cache.

(cherry picked from commit a828cf777a)
This commit is contained in:
Eelco Dolstra 2025-11-05 15:19:01 +01:00 • committed by github-actions[bot]
parent 038cc7913b
commit e6d823e46d
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/nix/flake.cc
View file

@ -798,8 +798,6 @@ struct CmdFlakeCheck : FlakeCommand
// via substitution, as `nix flake check` only needs to verify buildability, // via substitution, as `nix flake check` only needs to verify buildability,
// not actually produce the outputs. // not actually produce the outputs.
auto missing = store->queryMissing(drvPaths); auto missing = store->queryMissing(drvPaths);
// Only occurs if `drvPaths` contains a `DerivedPath::Opaque`, which should never happen
assert(missing.unknown.empty());
std::vector<DerivedPath> toBuild; std::vector<DerivedPath> toBuild;
for (auto & path : missing.willBuild) { for (auto & path : missing.willBuild) {