From ef17baf50d262c40a0761b39f1da6d24e0add375 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 10:05:59 -0700
Subject: [PATCH] shellcheck fix: tests/functional/parallel.sh

---
 maintainers/flake-module.nix |  1 -
 tests/functional/parallel.sh | 13 +++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 59adb8fdb..0a15c2362 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/parallel\.sh$''
               ''^tests/functional/pass-as-file\.sh$''
               ''^tests/functional/path-from-hash-part\.sh$''
               ''^tests/functional/path-info\.sh$''
diff --git a/tests/functional/parallel.sh b/tests/functional/parallel.sh
index 7e420688d..4d0bf0f1b 100644
--- a/tests/functional/parallel.sh
+++ b/tests/functional/parallel.sh
@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source common.sh
 
 
@@ -8,7 +9,7 @@ TODO_NixOS
 
 clearStore
 
-rm -f $_NIX_TEST_SHARED.cur $_NIX_TEST_SHARED.max
+rm -f "$_NIX_TEST_SHARED".cur "$_NIX_TEST_SHARED".max
 
 outPath=$(nix-build -j10000 parallel.nix --no-out-link)
 
@@ -17,8 +18,8 @@ echo "output path is $outPath"
 text=$(cat "$outPath")
 if test "$text" != "abacade"; then exit 1; fi
 
-if test "$(cat $_NIX_TEST_SHARED.cur)" != 0; then fail "wrong current process count"; fi
-if test "$(cat $_NIX_TEST_SHARED.max)" != 3; then fail "not enough parallelism"; fi
+if test "$(cat "$_NIX_TEST_SHARED".cur)" != 0; then fail "wrong current process count"; fi
+if test "$(cat "$_NIX_TEST_SHARED".max)" != 3; then fail "not enough parallelism"; fi
 
 
 # Second, test that parallel invocations of nix-build perform builds
@@ -27,7 +28,7 @@ echo "testing multiple nix-build -j1..."
 
 clearStore
 
-rm -f $_NIX_TEST_SHARED.cur $_NIX_TEST_SHARED.max
+rm -f "$_NIX_TEST_SHARED".cur "$_NIX_TEST_SHARED".max
 
 drvPath=$(nix-instantiate parallel.nix --argstr sleepTime 15)
 
@@ -54,5 +55,5 @@ wait $pid2 || fail "instance 2 failed: $?"
 wait $pid3 || fail "instance 3 failed: $?"
 wait $pid4 || fail "instance 4 failed: $?"
 
-if test "$(cat $_NIX_TEST_SHARED.cur)" != 0; then fail "wrong current process count"; fi
-if test "$(cat $_NIX_TEST_SHARED.max)" != 3; then fail "not enough parallelism"; fi
+if test "$(cat "$_NIX_TEST_SHARED".cur)" != 0; then fail "wrong current process count"; fi
+if test "$(cat "$_NIX_TEST_SHARED".max)" != 3; then fail "not enough parallelism"; fi