From 48eaf35828aecdecdd796cfc7d1de4357fb46221 Mon Sep 17 00:00:00 2001 From: Sergei Zimmerman Date: Fri, 12 Sep 2025 20:43:34 +0300 Subject: [PATCH] Revert "meson: add soversion to libraries (#13960)" This reverts commit bdbc739d6e87f2abf2ded4d38bb0e161f457eb68. Such a change needs more thought put into it. By versioning shared libraries we'd make a false impression that libraries themselves are actually versioned and have some sort of stable ABI, which is not the case. This will be useful when C bindings become stable, but as long as they are experimental it does not make sense to set SONAME. Also this change should not have been backported, since it's severely breaking. (cherry picked from commit 0db2b8c8fe3d944a289a12fee3b3d8ecbeec5240) --- src/libcmd/meson.build | 1 - src/libexpr-c/meson.build | 1 - src/libexpr-test-support/meson.build | 1 - src/libexpr/meson.build | 1 - src/libfetchers-c/meson.build | 1 - src/libfetchers/meson.build | 1 - src/libflake-c/meson.build | 1 - src/libflake/meson.build | 1 - src/libmain-c/meson.build | 1 - src/libmain/meson.build | 1 - src/libstore-c/meson.build | 1 - src/libstore-test-support/meson.build | 1 - src/libstore/meson.build | 1 - src/libutil-c/meson.build | 1 - src/libutil-test-support/meson.build | 1 - src/libutil/meson.build | 1 - 16 files changed, 16 deletions(-) diff --git a/src/libcmd/meson.build b/src/libcmd/meson.build index 6478fb226..24e075246 100644 --- a/src/libcmd/meson.build +++ b/src/libcmd/meson.build @@ -95,7 +95,6 @@ this_library = library( 'nixcmd', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libexpr-c/meson.build b/src/libexpr-c/meson.build index 01e60680b..7c014d61d 100644 --- a/src/libexpr-c/meson.build +++ b/src/libexpr-c/meson.build @@ -50,7 +50,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixexprc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libexpr-test-support/meson.build b/src/libexpr-test-support/meson.build index 1bc173ee4..d762eb85e 100644 --- a/src/libexpr-test-support/meson.build +++ b/src/libexpr-test-support/meson.build @@ -44,7 +44,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-expr-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libexpr/meson.build b/src/libexpr/meson.build index 8f0adf095..00fb82e3c 100644 --- a/src/libexpr/meson.build +++ b/src/libexpr/meson.build @@ -180,7 +180,6 @@ this_library = library( parser_tab, lexer_tab, generated_headers, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libfetchers-c/meson.build b/src/libfetchers-c/meson.build index 81b63780b..8542744b4 100644 --- a/src/libfetchers-c/meson.build +++ b/src/libfetchers-c/meson.build @@ -53,7 +53,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixfetchersc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libfetchers/meson.build b/src/libfetchers/meson.build index 7c5ce1bc9..922a2c491 100644 --- a/src/libfetchers/meson.build +++ b/src/libfetchers/meson.build @@ -61,7 +61,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixfetchers', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libflake-c/meson.build b/src/libflake-c/meson.build index e72694c2e..933e06d90 100644 --- a/src/libflake-c/meson.build +++ b/src/libflake-c/meson.build @@ -53,7 +53,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixflakec', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libflake/meson.build b/src/libflake/meson.build index cb5f128a4..191d8f068 100644 --- a/src/libflake/meson.build +++ b/src/libflake/meson.build @@ -58,7 +58,6 @@ this_library = library( 'nixflake', sources, generated_headers, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libmain-c/meson.build b/src/libmain-c/meson.build index 20b77aef2..9e26ad8ad 100644 --- a/src/libmain-c/meson.build +++ b/src/libmain-c/meson.build @@ -45,7 +45,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixmainc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libmain/meson.build b/src/libmain/meson.build index e70967462..4a90d2d83 100644 --- a/src/libmain/meson.build +++ b/src/libmain/meson.build @@ -77,7 +77,6 @@ this_library = library( 'nixmain', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libstore-c/meson.build b/src/libstore-c/meson.build index a48885780..f8eaef803 100644 --- a/src/libstore-c/meson.build +++ b/src/libstore-c/meson.build @@ -46,7 +46,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixstorec', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libstore-test-support/meson.build b/src/libstore-test-support/meson.build index 3a3ffe36e..b2977941f 100644 --- a/src/libstore-test-support/meson.build +++ b/src/libstore-test-support/meson.build @@ -44,7 +44,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-store-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libstore/meson.build b/src/libstore/meson.build index bc560f979..a275f4edc 100644 --- a/src/libstore/meson.build +++ b/src/libstore/meson.build @@ -361,7 +361,6 @@ this_library = library( generated_headers, sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libutil-c/meson.build b/src/libutil-c/meson.build index 9e1a43e80..8131c517c 100644 --- a/src/libutil-c/meson.build +++ b/src/libutil-c/meson.build @@ -53,7 +53,6 @@ this_library = library( 'nixutilc', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags, diff --git a/src/libutil-test-support/meson.build b/src/libutil-test-support/meson.build index 9ad139edb..910f1d881 100644 --- a/src/libutil-test-support/meson.build +++ b/src/libutil-test-support/meson.build @@ -41,7 +41,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-util-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libutil/meson.build b/src/libutil/meson.build index 131f71034..cdffc892a 100644 --- a/src/libutil/meson.build +++ b/src/libutil/meson.build @@ -197,7 +197,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixutil', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args : linker_export_flags,