nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-09 20:16:03 +01:00
Code Activity

lib{store,flake}-tests: Add test for spaces in URIs

Browse source 
These cases do not seem to be covered by the test suite at all.
This commit is contained in:
Sergei Zimmerman 2025-07-18 21:20:13 +03:00
parent b8d223a210
commit ffc9bfb66d
No known key found for this signature in database
3 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/libflake-tests/flakeref.cc
View file

@ -48,6 +48,13 @@ TEST(parseFlakeRef, path)
ASSERT_EQ(flakeref.to_string(), "path:/foo/bar?revCount=123"); ASSERT_EQ(flakeref.to_string(), "path:/foo/bar?revCount=123");
ASSERT_EQ(fragment, "bla"); ASSERT_EQ(fragment, "bla");
} }
{
auto s = "/foo bar/baz?dir=bla space";
auto flakeref = parseFlakeRef(fetchSettings, s);
ASSERT_EQ(flakeref.to_string(), "path:/foo%20bar/baz?dir=bla%20space");
ASSERT_EQ(flakeref.toAttrs().at("dir"), fetchers::Attr("bla space"));
}
} }
TEST(to_string, doesntReencodeUrl) TEST(to_string, doesntReencodeUrl)

1
src/libstore-tests/data/store-reference/local_3.txt Normal file
View file

@ -0,0 +1 @@
local://?root=/foo bar/baz

14
src/libstore-tests/store-reference.cc
View file

@ -85,10 +85,24 @@ static StoreReference localExample_2{
}, },
}; };
static StoreReference localExample_3{
.variant =
StoreReference::Specified{
.scheme = "local",
},
.params =
{
{"root", "/foo bar/baz"},
},
};
URI_TEST(local_1, localExample_1) URI_TEST(local_1, localExample_1)
URI_TEST(local_2, localExample_2) URI_TEST(local_2, localExample_2)
/* Test path with spaces */
URI_TEST(local_3, localExample_3)
URI_TEST_READ(local_shorthand_1, localExample_1) URI_TEST_READ(local_shorthand_1, localExample_1)
URI_TEST_READ(local_shorthand_2, localExample_2) URI_TEST_READ(local_shorthand_2, localExample_2)