mirror of
https://github.com/NixOS/nix.git
synced 2025-11-10 20:46:01 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
78 lines
2.3 KiB
Bash
78 lines
2.3 KiB
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
# Test fetching a flat file.
|
|
hash=$(nix-hash --flat --type sha256 ./fetchurl.sh)
|
|
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file://$(pwd)/fetchurl.sh --argstr sha256 $hash --no-out-link --hashed-mirrors '')
|
|
|
|
cmp $outPath fetchurl.sh
|
|
|
|
# Now using a base-64 hash.
|
|
clearStore
|
|
|
|
hash=$(nix hash-file --type sha512 --base64 ./fetchurl.sh)
|
|
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file://$(pwd)/fetchurl.sh --argstr sha512 $hash --no-out-link --hashed-mirrors '')
|
|
|
|
cmp $outPath fetchurl.sh
|
|
|
|
# Now using an SRI hash.
|
|
clearStore
|
|
|
|
hash=$(nix hash-file ./fetchurl.sh)
|
|
|
|
[[ $hash =~ ^sha256- ]]
|
|
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file://$(pwd)/fetchurl.sh --argstr hash $hash --no-out-link --hashed-mirrors '')
|
|
|
|
cmp $outPath fetchurl.sh
|
|
|
|
# Test the hashed mirror feature.
|
|
clearStore
|
|
|
|
hash=$(nix hash-file --type sha512 --base64 ./fetchurl.sh)
|
|
hash32=$(nix hash-file --type sha512 --base16 ./fetchurl.sh)
|
|
|
|
mirror=$TMPDIR/hashed-mirror
|
|
rm -rf $mirror
|
|
mkdir -p $mirror/sha512
|
|
ln -s $(pwd)/fetchurl.sh $mirror/sha512/$hash32
|
|
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file:///no-such-dir/fetchurl.sh --argstr sha512 $hash --no-out-link --hashed-mirrors "file://$mirror")
|
|
|
|
# Test hashed mirrors with an SRI hash.
|
|
nix-build '<nix/fetchurl.nix>' --argstr url file:///no-such-dir/fetchurl.sh --argstr hash $(nix to-sri --type sha512 $hash) \
|
|
--argstr name bla --no-out-link --hashed-mirrors "file://$mirror"
|
|
|
|
# Test unpacking a NAR.
|
|
rm -rf $TEST_ROOT/archive
|
|
mkdir -p $TEST_ROOT/archive
|
|
cp ./fetchurl.sh $TEST_ROOT/archive
|
|
chmod +x $TEST_ROOT/archive/fetchurl.sh
|
|
ln -s foo $TEST_ROOT/archive/symlink
|
|
nar=$TEST_ROOT/archive.nar
|
|
nix-store --dump $TEST_ROOT/archive > $nar
|
|
|
|
hash=$(nix-hash --flat --type sha256 $nar)
|
|
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file://$nar --argstr sha256 $hash \
|
|
--arg unpack true --argstr name xyzzy --no-out-link)
|
|
|
|
echo $outPath | grepQuiet 'xyzzy'
|
|
|
|
test -x $outPath/fetchurl.sh
|
|
test -L $outPath/symlink
|
|
|
|
nix-store --delete $outPath
|
|
|
|
# Test unpacking a compressed NAR.
|
|
narxz=$TEST_ROOT/archive.nar.xz
|
|
rm -f $narxz
|
|
xz --keep $nar
|
|
outPath=$(nix-build '<nix/fetchurl.nix>' --argstr url file://$narxz --argstr sha256 $hash \
|
|
--arg unpack true --argstr name xyzzy --no-out-link)
|
|
|
|
test -x $outPath/fetchurl.sh
|
|
test -L $outPath/symlink
|