mirror of
https://github.com/NixOS/nix.git
synced 2025-11-09 12:06:01 +01:00
1b7ffa53af
The problem with old code was that it used getUri for both the `diskCache` as well as logging. This is really bad because it mixes the textual human readable representation with the caching. Also using getUri for the cache key is really problematic for the S3 store, since it doesn't include the `endpoint` in the cache key, so it's totally broken. This starts separating the logging / cache concerns by introducing a `getHumanReadableURI` that should only be used for logging. The caching logic now instead uses `getReference().render(/*withParams=*/false)` exclusively. This would need to be fixed in follow-ups, because that's really fragile and broken for some store types (but it was already broken before).
57 lines
1.3 KiB
C++
57 lines
1.3 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include "nix/store/ssh-store.hh"
|
|
#include "nix/util/config-impl.hh"
|
|
#include "nix/util/abstract-setting-to-json.hh"
|
|
|
|
namespace nix {
|
|
|
|
TEST(SSHStore, constructConfig)
|
|
{
|
|
SSHStoreConfig config{
|
|
"ssh-ng",
|
|
"me@localhost:2222",
|
|
StoreConfig::Params{
|
|
{
|
|
"remote-program",
|
|
// TODO #11106, no more split on space
|
|
"foo bar",
|
|
},
|
|
},
|
|
};
|
|
|
|
EXPECT_EQ(
|
|
config.remoteProgram.get(),
|
|
(Strings{
|
|
"foo",
|
|
"bar",
|
|
}));
|
|
|
|
EXPECT_EQ(config.getReference().render(/*withParams=*/true), "ssh-ng://me@localhost:2222?remote-program=foo%20bar");
|
|
config.resetOverridden();
|
|
EXPECT_EQ(config.getReference().render(/*withParams=*/true), "ssh-ng://me@localhost:2222");
|
|
}
|
|
|
|
TEST(MountedSSHStore, constructConfig)
|
|
{
|
|
MountedSSHStoreConfig config{
|
|
"mounted-ssh",
|
|
"localhost",
|
|
StoreConfig::Params{
|
|
{
|
|
"remote-program",
|
|
// TODO #11106, no more split on space
|
|
"foo bar",
|
|
},
|
|
},
|
|
};
|
|
|
|
EXPECT_EQ(
|
|
config.remoteProgram.get(),
|
|
(Strings{
|
|
"foo",
|
|
"bar",
|
|
}));
|
|
}
|
|
|
|
} // namespace nix
|