1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-14 22:42:41 +01:00
nix/src/libstore
Sergei Zimmerman 1b7ffa53af
treewide: Remove getUri and replace with getHumanReadableURI where appropriate
The problem with old code was that it used getUri for both the `diskCache`
as well as logging. This is really bad because it mixes the textual human
readable representation with the caching.

Also using getUri for the cache key is really problematic for the S3 store,
since it doesn't include the `endpoint` in the cache key, so it's totally broken.

This starts separating the logging / cache concerns by introducing a
`getHumanReadableURI` that should only be used for logging. The caching
logic now instead uses `getReference().render(/*withParams=*/false)` exclusively.
This would need to be fixed in follow-ups, because that's really fragile and
broken for some store types (but it was already broken before).
2025-08-14 16:47:05 +03:00
..
build treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
builtins libstore: Move State to an anonymous namespace 2025-08-05 02:15:21 +03:00
include/nix/store treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
linux Merge pull request #13490 from Mic92/clang-tidy-simple-warnings 2025-08-11 18:21:46 +02:00
pch libstore: Speed up builds by using precompiled headers 2025-07-20 22:01:53 +03:00
unix libutil: Make HashResult a proper struct 2025-08-08 02:06:14 +03:00
windows meson: Apply formatting universally 2025-08-07 02:58:29 +03:00
.version Build nix-store with Meson 2024-06-14 10:25:14 -04:00
binary-cache-store.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
build-result.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
ca-specific-schema.sql Rename to "content-address*ing* derivation" 2025-02-10 01:12:56 -05:00
common-protocol.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
common-ssh-store-config.cc Add user@address:port support 2025-08-06 23:48:14 +03:00
content-address.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
daemon.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
derivation-options.cc Merge pull request #13490 from Mic92/clang-tidy-simple-warnings 2025-08-11 18:21:46 +02:00
derivations.cc speedup derivation parsing 2025-08-05 22:00:30 +02:00
derived-path-map.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
derived-path.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
downstream-placeholder.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
dummy-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
dummy-store.md Support per-store Markdown documentation 2023-03-21 14:03:40 +01:00
export-import.cc libutil: Make HashResult a proper struct 2025-08-08 02:06:14 +03:00
filetransfer.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
gc.cc libstore: Remove dead variable 2025-08-05 14:03:38 +02:00
globals.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
http-binary-cache-store.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
http-binary-cache-store.md Support per-store Markdown documentation 2023-03-21 14:03:40 +01:00
indirect-root-store.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
keys.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
legacy-ssh-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
legacy-ssh-store.md Add user@address:port support 2025-08-06 23:48:14 +03:00
local-binary-cache-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
local-binary-cache-store.md Support per-store Markdown documentation 2023-03-21 14:03:40 +01:00
local-fs-store.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
local-overlay-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
local-overlay-store.md docs: Fix miscellaneous typos and formatting issues 2025-05-13 22:20:11 +00:00
local-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
local-store.md Build the local store on Windows 2024-05-10 13:05:23 -04:00
log-store.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
machines.cc Clean up Base* code 2025-08-06 11:51:44 -04:00
make-content-addressed.cc libutil: Move references.{hh,cc} to libstore 2025-08-08 10:30:09 +03:00
meson.build libutil: Move references.{hh,cc} to libstore 2025-08-08 10:30:09 +03:00
meson.options meson: Apply formatting universally 2025-08-07 02:58:29 +03:00
misc.cc Store StructuredAttrs directly in Derivation 2025-07-29 17:28:16 -04:00
mounted-ssh-store.md MountedSSHStore: stores on shared filesystems 2023-11-21 13:34:01 -05:00
names.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
nar-accessor.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
nar-info-disk-cache.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
nar-info.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
nix-meson-build-support rename: build-utils-meson -> nix-meson-build-support 2024-12-09 16:54:42 +01:00
optimise-store.cc libutil: Make HashResult a proper struct 2025-08-08 02:06:14 +03:00
outputs-spec.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
package.nix Expose the nix component in header include paths 2025-04-01 11:40:42 -04:00
parsed-derivations.cc speedup derivation parsing 2025-08-05 22:00:30 +02:00
path-info.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
path-references.cc libstore: Remove unused overload of scanForReferences 2025-08-08 10:30:07 +03:00
path-with-outputs.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
path.cc Move some MixStoreDirMethods members to the right .cc file 2025-08-06 20:13:15 -04:00
pathlocks.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
posix-fs-canonicalise.cc libstore: always canonicalize directory permissions 2025-08-06 10:58:46 -05:00
profiles.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
realisation.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
references.cc libutil: Move references.{hh,cc} to libstore 2025-08-08 10:30:09 +03:00
remote-fs-accessor.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
remote-store.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
restricted-store.cc getUri should be const and on Store::Config not Store 2025-08-11 17:44:50 -04:00
s3-binary-cache-store.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
s3-binary-cache-store.md fix location 2024-09-27 11:07:04 +02:00
schema.sql Build the local store on Windows 2024-05-10 13:05:23 -04:00
serve-protocol-connection.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
serve-protocol.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
sqlite.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
ssh-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
ssh-store.md Add user@address:port support 2025-08-06 23:48:14 +03:00
ssh.cc Fix Git LFS SSH issues 2025-08-13 21:04:29 +03:00
store-api.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
store-dir-config.cc Move some MixStoreDirMethods members to the right .cc file 2025-08-06 20:13:15 -04:00
store-reference.cc treewide: Remove getUri and replace with getHumanReadableURI where appropriate 2025-08-14 16:47:05 +03:00
store-registration.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
uds-remote-store.cc Rewrite StoreConfig::getUri in terms of new StoreConfig::getReference 2025-08-13 19:06:59 -04:00
uds-remote-store.md Enable the unix:// store on Windows 2024-04-18 16:58:32 -04:00
worker-protocol-connection.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00
worker-protocol.cc Apply clang-format universally. 2025-07-18 12:47:27 -04:00