mirror of
https://github.com/NixOS/nix.git
synced 2025-12-23 17:31:08 +01:00
24bda0c7b3
This has been the behaviour before Nix 2.4. It was dropped in a rewrite
in 759947bf72, allowing the creation of
store paths that aren't considered valid by older Nix versions or other
Nix tooling.
Nix 2.4 didn't ship in NixOS until 22.05, and stdenv.mkDerivation in
nixpkgs drops leading periods since April 2022, so it's unlikely anyone
is relying on the current lax behaviour.
Closes #9091.
Change-Id: I4a57bd9899e1b0dba56870ae5a1b680918a18ce9
162 lines
4 KiB
C++
162 lines
4 KiB
C++
#include <regex>
|
|
|
|
#include <nlohmann/json.hpp>
|
|
#include <gtest/gtest.h>
|
|
#include <rapidcheck/gtest.h>
|
|
|
|
#include "path-regex.hh"
|
|
#include "store-api.hh"
|
|
|
|
#include "tests/hash.hh"
|
|
#include "tests/libstore.hh"
|
|
#include "tests/path.hh"
|
|
|
|
namespace nix {
|
|
|
|
#define STORE_DIR "/nix/store/"
|
|
#define HASH_PART "g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q"
|
|
|
|
class StorePathTest : public LibStoreTest
|
|
{
|
|
};
|
|
|
|
static std::regex nameRegex { std::string { nameRegexStr } };
|
|
|
|
#define TEST_DONT_PARSE(NAME, STR) \
|
|
TEST_F(StorePathTest, bad_ ## NAME) { \
|
|
std::string_view str = \
|
|
STORE_DIR HASH_PART "-" STR; \
|
|
ASSERT_THROW( \
|
|
store->parseStorePath(str), \
|
|
BadStorePath); \
|
|
std::string name { STR }; \
|
|
EXPECT_FALSE(std::regex_match(name, nameRegex)); \
|
|
}
|
|
|
|
TEST_DONT_PARSE(empty, "")
|
|
TEST_DONT_PARSE(garbage, "&*()")
|
|
TEST_DONT_PARSE(double_star, "**")
|
|
TEST_DONT_PARSE(star_first, "*,foo")
|
|
TEST_DONT_PARSE(star_second, "foo,*")
|
|
TEST_DONT_PARSE(bang, "foo!o")
|
|
TEST_DONT_PARSE(dotfile, ".gitignore")
|
|
|
|
#undef TEST_DONT_PARSE
|
|
|
|
#define TEST_DO_PARSE(NAME, STR) \
|
|
TEST_F(StorePathTest, good_ ## NAME) { \
|
|
std::string_view str = \
|
|
STORE_DIR HASH_PART "-" STR; \
|
|
auto p = store->parseStorePath(str); \
|
|
std::string name { p.name() }; \
|
|
EXPECT_TRUE(std::regex_match(name, nameRegex)); \
|
|
}
|
|
|
|
// 0-9 a-z A-Z + - . _ ? =
|
|
|
|
TEST_DO_PARSE(numbers, "02345")
|
|
TEST_DO_PARSE(lower_case, "foo")
|
|
TEST_DO_PARSE(upper_case, "FOO")
|
|
TEST_DO_PARSE(plus, "foo+bar")
|
|
TEST_DO_PARSE(dash, "foo-dev")
|
|
TEST_DO_PARSE(underscore, "foo_bar")
|
|
TEST_DO_PARSE(period, "foo.txt")
|
|
TEST_DO_PARSE(question_mark, "foo?why")
|
|
TEST_DO_PARSE(equals_sign, "foo=foo")
|
|
|
|
#undef TEST_DO_PARSE
|
|
|
|
// For rapidcheck
|
|
void showValue(const StorePath & p, std::ostream & os) {
|
|
os << p.to_string();
|
|
}
|
|
|
|
}
|
|
|
|
namespace rc {
|
|
using namespace nix;
|
|
|
|
Gen<StorePathName> Arbitrary<StorePathName>::arbitrary()
|
|
{
|
|
auto len = *gen::inRange<size_t>(
|
|
1,
|
|
StorePath::MaxPathLen - std::string_view { HASH_PART }.size());
|
|
|
|
std::string pre;
|
|
pre.reserve(len);
|
|
|
|
for (size_t c = 0; c < len; ++c) {
|
|
switch (auto i = *gen::inRange<uint8_t>(0, 10 + 2 * 26 + 6)) {
|
|
case 0 ... 9:
|
|
pre += '0' + i;
|
|
case 10 ... 35:
|
|
pre += 'A' + (i - 10);
|
|
break;
|
|
case 36 ... 61:
|
|
pre += 'a' + (i - 36);
|
|
break;
|
|
case 62:
|
|
pre += '+';
|
|
break;
|
|
case 63:
|
|
pre += '-';
|
|
break;
|
|
case 64:
|
|
// names aren't permitted to start with a period,
|
|
// so just fall through to the next case here
|
|
if (c != 0) {
|
|
pre += '.';
|
|
break;
|
|
}
|
|
case 65:
|
|
pre += '_';
|
|
break;
|
|
case 66:
|
|
pre += '?';
|
|
break;
|
|
case 67:
|
|
pre += '=';
|
|
break;
|
|
default:
|
|
assert(false);
|
|
}
|
|
}
|
|
|
|
return gen::just(StorePathName {
|
|
.name = std::move(pre),
|
|
});
|
|
}
|
|
|
|
Gen<StorePath> Arbitrary<StorePath>::arbitrary()
|
|
{
|
|
return gen::just(StorePath {
|
|
*gen::arbitrary<Hash>(),
|
|
(*gen::arbitrary<StorePathName>()).name,
|
|
});
|
|
}
|
|
|
|
} // namespace rc
|
|
|
|
namespace nix {
|
|
|
|
#ifndef COVERAGE
|
|
|
|
RC_GTEST_FIXTURE_PROP(
|
|
StorePathTest,
|
|
prop_regex_accept,
|
|
(const StorePath & p))
|
|
{
|
|
RC_ASSERT(std::regex_match(std::string { p.name() }, nameRegex));
|
|
}
|
|
|
|
RC_GTEST_FIXTURE_PROP(
|
|
StorePathTest,
|
|
prop_round_rip,
|
|
(const StorePath & p))
|
|
{
|
|
RC_ASSERT(p == store->parseStorePath(store->printStorePath(p)));
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|