mirror of
https://github.com/NixOS/nix.git
synced 2025-11-29 21:50:58 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
52 lines
1.3 KiB
Bash
52 lines
1.3 KiB
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
drvPath=$(nix-instantiate dependencies.nix)
|
|
|
|
echo "derivation is $drvPath"
|
|
|
|
nix-store -q --tree "$drvPath" | grep ' +---.*builder1.sh'
|
|
|
|
# Test Graphviz graph generation.
|
|
nix-store -q --graph "$drvPath" > $TEST_ROOT/graph
|
|
if test -n "$dot"; then
|
|
# Does it parse?
|
|
$dot < $TEST_ROOT/graph
|
|
fi
|
|
|
|
outPath=$(nix-store -rvv "$drvPath") || fail "build failed"
|
|
|
|
# Test Graphviz graph generation.
|
|
nix-store -q --graph "$outPath" > $TEST_ROOT/graph
|
|
if test -n "$dot"; then
|
|
# Does it parse?
|
|
$dot < $TEST_ROOT/graph
|
|
fi
|
|
|
|
nix-store -q --tree "$outPath" | grep '+---.*dependencies-input-2'
|
|
|
|
echo "output path is $outPath"
|
|
|
|
text=$(cat "$outPath"/foobar)
|
|
if test "$text" != "FOOBAR"; then exit 1; fi
|
|
|
|
deps=$(nix-store -quR "$drvPath")
|
|
|
|
echo "output closure contains $deps"
|
|
|
|
# The output path should be in the closure.
|
|
echo "$deps" | grepQuiet "$outPath"
|
|
|
|
# Input-1 is not retained.
|
|
if echo "$deps" | grepQuiet "dependencies-input-1"; then exit 1; fi
|
|
|
|
# Input-2 is retained.
|
|
input2OutPath=$(echo "$deps" | grep "dependencies-input-2")
|
|
|
|
# The referrers closure of input-2 should include outPath.
|
|
nix-store -q --referrers-closure "$input2OutPath" | grep "$outPath"
|
|
|
|
# Check that the derivers are set properly.
|
|
test $(nix-store -q --deriver "$outPath") = "$drvPath"
|
|
nix-store -q --deriver "$input2OutPath" | grepQuiet -- "-input-2.drv"
|