mirror of
https://github.com/NixOS/nix.git
synced 2025-11-12 05:26:02 +01:00
b5947b55e2
As discussed in the maintainer meeting on 2024-01-29.
Mainly this is to avoid a situation where the name is parsed and
treated as a file name, mostly to protect users.
.-* and ..-* are also considered invalid because they might strip
on that separator to remove versions. Doesn't really work, but that's
what we decided, and I won't argue with it, because .-* probably
doesn't seem to have a real world application anyway.
We do still permit a 1-character name that's just "-", which still
poses a similar risk in such a situation. We can't start disallowing
trailing -, because a non-zero number of users will need it and we've
seen how annoying and painful such a change is.
What matters most is preventing a situation where . or .. can be
injected, and to just get this done.
(cherry picked from commit f1b4663805)
13 lines
382 B
C++
13 lines
382 B
C++
#pragma once
|
|
///@file
|
|
|
|
namespace nix {
|
|
|
|
|
|
static constexpr std::string_view nameRegexStr =
|
|
// This uses a negative lookahead: (?!\.\.?(-|$))
|
|
// - deny ".", "..", or those strings followed by '-'
|
|
// - when it's not those, start again at the start of the input and apply the next regex, which is [0-9a-zA-Z\+\-\._\?=]+
|
|
R"((?!\.\.?(-|$))[0-9a-zA-Z\+\-\._\?=]+)";
|
|
|
|
}
|