mirror of
https://github.com/NixOS/nix.git
synced 2025-11-11 04:56:01 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
29 lines
624 B
Bash
Executable file
29 lines
624 B
Bash
Executable file
#!/bin/sh
|
||
|
||
set -eu -o pipefail
|
||
|
||
red=""
|
||
green=""
|
||
yellow=""
|
||
normal=""
|
||
|
||
post_run_msg="ran test $1..."
|
||
if [ -t 1 ]; then
|
||
red="[31;1m"
|
||
green="[32;1m"
|
||
yellow="[33;1m"
|
||
normal="[m"
|
||
fi
|
||
(cd $(dirname $1) && env ${TESTS_ENVIRONMENT} init.sh 2>/dev/null > /dev/null)
|
||
|
||
log="$(cd $(dirname $1) && env ${TESTS_ENVIRONMENT} $(basename $1) 2>&1)" && status=0 || status=$?
|
||
|
||
if [ $status -eq 0 ]; then
|
||
echo "$post_run_msg [${green}PASS$normal]"
|
||
elif [ $status -eq 99 ]; then
|
||
echo "$post_run_msg [${yellow}SKIP$normal]"
|
||
else
|
||
echo "$post_run_msg [${red}FAIL$normal]"
|
||
echo "$log" | sed 's/^/ /'
|
||
exit "$status"
|
||
fi
|