mirror of
https://github.com/NixOS/nix.git
synced 2025-11-13 14:02:42 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
44 lines
1.8 KiB
Bash
44 lines
1.8 KiB
Bash
source common.sh
|
|
|
|
echo "building test path"
|
|
storePath="$(nix-build nar-access.nix -A a --no-out-link)"
|
|
|
|
cd "$TEST_ROOT"
|
|
|
|
# Dump path to nar.
|
|
narFile="$TEST_ROOT/path.nar"
|
|
nix-store --dump $storePath > $narFile
|
|
|
|
# Check that find and ls-nar match.
|
|
( cd $storePath; find . | sort ) > files.find
|
|
nix ls-nar -R -d $narFile "" | sort > files.ls-nar
|
|
diff -u files.find files.ls-nar
|
|
|
|
# Check that file contents of data match.
|
|
nix cat-nar $narFile /foo/data > data.cat-nar
|
|
diff -u data.cat-nar $storePath/foo/data
|
|
|
|
# Check that file contents of baz match.
|
|
nix cat-nar $narFile /foo/baz > baz.cat-nar
|
|
diff -u baz.cat-nar $storePath/foo/baz
|
|
|
|
nix cat-store $storePath/foo/baz > baz.cat-nar
|
|
diff -u baz.cat-nar $storePath/foo/baz
|
|
|
|
# Test --json.
|
|
[[ $(nix ls-nar --json $narFile /) = '{"type":"directory","entries":{"foo":{},"foo-x":{},"qux":{},"zyx":{}}}' ]]
|
|
[[ $(nix ls-nar --json -R $narFile /foo) = '{"type":"directory","entries":{"bar":{"type":"regular","size":0,"narOffset":368},"baz":{"type":"regular","size":0,"narOffset":552},"data":{"type":"regular","size":58,"narOffset":736}}}' ]]
|
|
[[ $(nix ls-nar --json -R $narFile /foo/bar) = '{"type":"regular","size":0,"narOffset":368}' ]]
|
|
[[ $(nix ls-store --json $storePath) = '{"type":"directory","entries":{"foo":{},"foo-x":{},"qux":{},"zyx":{}}}' ]]
|
|
[[ $(nix ls-store --json -R $storePath/foo) = '{"type":"directory","entries":{"bar":{"type":"regular","size":0},"baz":{"type":"regular","size":0},"data":{"type":"regular","size":58}}}' ]]
|
|
[[ $(nix ls-store --json -R $storePath/foo/bar) = '{"type":"regular","size":0}' ]]
|
|
|
|
# Test missing files.
|
|
expect 1 nix ls-store --json -R $storePath/xyzzy 2>&1 | grep 'does not exist in NAR'
|
|
expect 1 nix ls-store $storePath/xyzzy 2>&1 | grep 'does not exist'
|
|
|
|
# Test failure to dump.
|
|
if nix-store --dump $storePath >/dev/full ; then
|
|
echo "dumping to /dev/full should fail"
|
|
exit -1
|
|
fi
|