mirror of
https://github.com/NixOS/nix.git
synced 2025-11-11 04:56:01 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
59 lines
1.8 KiB
Bash
59 lines
1.8 KiB
Bash
source common.sh
|
|
|
|
clearProfiles
|
|
|
|
rm -f $TEST_HOME/.nix-channels $TEST_HOME/.nix-profile
|
|
|
|
# Test add/list/remove.
|
|
nix-channel --add http://foo/bar xyzzy
|
|
nix-channel --list | grepQuiet http://foo/bar
|
|
nix-channel --remove xyzzy
|
|
|
|
[ -e $TEST_HOME/.nix-channels ]
|
|
[ "$(cat $TEST_HOME/.nix-channels)" = '' ]
|
|
|
|
# Create a channel.
|
|
rm -rf $TEST_ROOT/foo
|
|
mkdir -p $TEST_ROOT/foo
|
|
nix copy --to file://$TEST_ROOT/foo?compression="bzip2" $(nix-store -r $(nix-instantiate dependencies.nix))
|
|
rm -rf $TEST_ROOT/nixexprs
|
|
mkdir -p $TEST_ROOT/nixexprs
|
|
cp config.nix dependencies.nix dependencies.builder*.sh $TEST_ROOT/nixexprs/
|
|
ln -s dependencies.nix $TEST_ROOT/nixexprs/default.nix
|
|
(cd $TEST_ROOT && tar cvf - nixexprs) | bzip2 > $TEST_ROOT/foo/nixexprs.tar.bz2
|
|
|
|
# Test the update action.
|
|
nix-channel --add file://$TEST_ROOT/foo
|
|
nix-channel --update
|
|
|
|
# Do a query.
|
|
nix-env -qa \* --meta --xml --out-path > $TEST_ROOT/meta.xml
|
|
if [ "$xmllint" != false ]; then
|
|
$xmllint --noout $TEST_ROOT/meta.xml || fail "malformed XML"
|
|
fi
|
|
grepQuiet 'meta.*description.*Random test package' $TEST_ROOT/meta.xml
|
|
grepQuiet 'item.*attrPath="foo".*name="dependencies"' $TEST_ROOT/meta.xml
|
|
|
|
# Do an install.
|
|
nix-env -i dependencies
|
|
[ -e $TEST_HOME/.nix-profile/foobar ]
|
|
|
|
clearProfiles
|
|
rm -f $TEST_HOME/.nix-channels
|
|
|
|
# Test updating from a tarball
|
|
nix-channel --add file://$TEST_ROOT/foo/nixexprs.tar.bz2 foo
|
|
nix-channel --update
|
|
|
|
# Do a query.
|
|
nix-env -qa \* --meta --xml --out-path > $TEST_ROOT/meta.xml
|
|
if [ "$xmllint" != false ]; then
|
|
$xmllint --noout $TEST_ROOT/meta.xml || fail "malformed XML"
|
|
fi
|
|
grepQuiet 'meta.*description.*Random test package' $TEST_ROOT/meta.xml
|
|
grepQuiet 'item.*attrPath="foo".*name="dependencies"' $TEST_ROOT/meta.xml
|
|
|
|
# Do an install.
|
|
nix-env -i dependencies
|
|
[ -e $TEST_HOME/.nix-profile/foobar ]
|
|
|