mirror of
https://github.com/NixOS/nix.git
synced 2025-11-21 17:59:36 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
43 lines
1.1 KiB
Bash
43 lines
1.1 KiB
Bash
source common.sh
|
|
|
|
clearStore
|
|
clearCache
|
|
|
|
# No packages
|
|
(( $(NIX_PATH= nix search -u|wc -l) == 0 ))
|
|
|
|
# Haven't updated cache, still nothing
|
|
(( $(nix search -f search.nix hello|wc -l) == 0 ))
|
|
(( $(nix search -f search.nix |wc -l) == 0 ))
|
|
|
|
# Update cache, search should work
|
|
(( $(nix search -f search.nix -u hello|wc -l) > 0 ))
|
|
|
|
# Use cache
|
|
(( $(nix search -f search.nix foo|wc -l) > 0 ))
|
|
(( $(nix search foo|wc -l) > 0 ))
|
|
|
|
# Test --no-cache works
|
|
# No results from cache
|
|
(( $(nix search --no-cache foo |wc -l) == 0 ))
|
|
# Does find results from file pointed at
|
|
(( $(nix search -f search.nix --no-cache foo |wc -l) > 0 ))
|
|
|
|
# Check descriptions are searched
|
|
(( $(nix search broken | wc -l) > 0 ))
|
|
|
|
# Check search that matches nothing
|
|
(( $(nix search nosuchpackageexists | wc -l) == 0 ))
|
|
|
|
# Search for multiple arguments
|
|
(( $(nix search hello empty | wc -l) == 3 ))
|
|
|
|
# Multiple arguments will not exist
|
|
(( $(nix search hello broken | wc -l) == 0 ))
|
|
|
|
## Search expressions
|
|
|
|
# Check that empty search string matches all
|
|
nix search|grepQuiet foo
|
|
nix search|grepQuiet bar
|
|
nix search|grepQuiet hello
|