mirror of
https://github.com/NixOS/nix.git
synced 2025-11-17 16:02:43 +01:00
67ab776e15
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.
- `set -u` catches the use of undefined variables
- `set -o pipefail` catches failures (like `set -e`) earlier in the
pipeline.
This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.
There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.
To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.
`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.
`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.
`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.
(cherry picked from commit c11836126b)
28 lines
893 B
Bash
28 lines
893 B
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
rm -rf $TEST_HOME
|
|
|
|
tarroot=$TEST_ROOT/tarball
|
|
rm -rf $tarroot
|
|
mkdir -p $tarroot
|
|
cp dependencies.nix $tarroot/default.nix
|
|
cp config.nix dependencies.builder*.sh $tarroot/
|
|
|
|
tarball=$TEST_ROOT/tarball.tar.xz
|
|
(cd $TEST_ROOT && tar cf - tarball) | xz > $tarball
|
|
|
|
nix-env -f file://$tarball -qa --out-path | grepQuiet dependencies
|
|
|
|
nix-build -o $TEST_ROOT/result file://$tarball
|
|
|
|
nix-build -o $TEST_ROOT/result '<foo>' -I foo=file://$tarball
|
|
|
|
nix-build -o $TEST_ROOT/result -E "import (fetchTarball file://$tarball)"
|
|
|
|
nix-instantiate --eval -E '1 + 2' -I fnord=file://no-such-tarball.tar.xz
|
|
nix-instantiate --eval -E 'with <fnord/xyzzy>; 1 + 2' -I fnord=file://no-such-tarball.tar.xz
|
|
(! nix-instantiate --eval -E '<fnord/xyzzy> 1' -I fnord=file://no-such-tarball.tar.xz)
|
|
|
|
nix-instantiate --eval -E '<fnord/config.nix>' -I fnord=file://no-such-tarball.tar.xz -I fnord=.
|