mirror of
https://github.com/NixOS/nix.git
synced 2025-11-09 03:56:01 +01:00
Fixes usage of `#` symbol in the reference name. This also seems to identify several deficiencies in the libgit2 refname validation code wrt to DEL symbol and a singular `@` symbol [1]. [1]: https://git-scm.com/docs/git-check-ref-format#_description
230 lines
7.9 KiB
C++
230 lines
7.9 KiB
C++
#include "nix/fetchers/git-utils.hh"
|
|
#include "nix/util/file-system.hh"
|
|
#include <gmock/gmock.h>
|
|
#include <git2/global.h>
|
|
#include <git2/repository.h>
|
|
#include <git2/signature.h>
|
|
#include <git2/types.h>
|
|
#include <git2/object.h>
|
|
#include <git2/tag.h>
|
|
#include <gtest/gtest.h>
|
|
#include "nix/util/fs-sink.hh"
|
|
#include "nix/util/serialise.hh"
|
|
#include "nix/fetchers/git-lfs-fetch.hh"
|
|
|
|
#include <git2/blob.h>
|
|
#include <git2/tree.h>
|
|
|
|
namespace nix {
|
|
|
|
class GitUtilsTest : public ::testing::Test
|
|
{
|
|
// We use a single repository for all tests.
|
|
std::unique_ptr<AutoDelete> delTmpDir;
|
|
|
|
protected:
|
|
std::filesystem::path tmpDir;
|
|
|
|
public:
|
|
void SetUp() override
|
|
{
|
|
tmpDir = createTempDir();
|
|
delTmpDir = std::make_unique<AutoDelete>(tmpDir, true);
|
|
|
|
// Create the repo with libgit2
|
|
git_libgit2_init();
|
|
git_repository * repo = nullptr;
|
|
auto r = git_repository_init(&repo, tmpDir.string().c_str(), 0);
|
|
ASSERT_EQ(r, 0);
|
|
git_repository_free(repo);
|
|
}
|
|
|
|
void TearDown() override
|
|
{
|
|
// Destroy the AutoDelete, triggering removal
|
|
// not AutoDelete::reset(), which would cancel the deletion.
|
|
delTmpDir.reset();
|
|
}
|
|
|
|
ref<GitRepo> openRepo()
|
|
{
|
|
return GitRepo::openRepo(tmpDir, true, false);
|
|
}
|
|
|
|
std::string getRepoName() const
|
|
{
|
|
return tmpDir.filename().string();
|
|
}
|
|
};
|
|
|
|
void writeString(CreateRegularFileSink & fileSink, std::string contents, bool executable)
|
|
{
|
|
if (executable)
|
|
fileSink.isExecutable();
|
|
fileSink.preallocateContents(contents.size());
|
|
fileSink(contents);
|
|
}
|
|
|
|
TEST_F(GitUtilsTest, sink_basic)
|
|
{
|
|
auto repo = openRepo();
|
|
auto sink = repo->getFileSystemObjectSink();
|
|
|
|
// TODO/Question: It seems a little odd that we use the tarball-like convention of requiring a top-level directory
|
|
// here
|
|
// The sync method does not document this behavior, should probably renamed because it's not very
|
|
// general, and I can't imagine that "non-conventional" archives or any other source to be handled by
|
|
// this sink.
|
|
|
|
sink->createDirectory(CanonPath("foo-1.1"));
|
|
|
|
sink->createRegularFile(CanonPath("foo-1.1/hello"), [](CreateRegularFileSink & fileSink) {
|
|
writeString(fileSink, "hello world", false);
|
|
});
|
|
sink->createRegularFile(CanonPath("foo-1.1/bye"), [](CreateRegularFileSink & fileSink) {
|
|
writeString(fileSink, "thanks for all the fish", false);
|
|
});
|
|
sink->createSymlink(CanonPath("foo-1.1/bye-link"), "bye");
|
|
sink->createDirectory(CanonPath("foo-1.1/empty"));
|
|
sink->createDirectory(CanonPath("foo-1.1/links"));
|
|
sink->createHardlink(CanonPath("foo-1.1/links/foo"), CanonPath("foo-1.1/hello"));
|
|
|
|
// sink->createHardlink("foo-1.1/links/foo-2", CanonPath("foo-1.1/hello"));
|
|
|
|
auto result = repo->dereferenceSingletonDirectory(sink->flush());
|
|
auto accessor = repo->getAccessor(result, false, getRepoName());
|
|
auto entries = accessor->readDirectory(CanonPath::root);
|
|
ASSERT_EQ(entries.size(), 5u);
|
|
ASSERT_EQ(accessor->readFile(CanonPath("hello")), "hello world");
|
|
ASSERT_EQ(accessor->readFile(CanonPath("bye")), "thanks for all the fish");
|
|
ASSERT_EQ(accessor->readLink(CanonPath("bye-link")), "bye");
|
|
ASSERT_EQ(accessor->readDirectory(CanonPath("empty")).size(), 0u);
|
|
ASSERT_EQ(accessor->readFile(CanonPath("links/foo")), "hello world");
|
|
};
|
|
|
|
TEST_F(GitUtilsTest, sink_hardlink)
|
|
{
|
|
auto repo = openRepo();
|
|
auto sink = repo->getFileSystemObjectSink();
|
|
|
|
sink->createDirectory(CanonPath("foo-1.1"));
|
|
|
|
sink->createRegularFile(CanonPath("foo-1.1/hello"), [](CreateRegularFileSink & fileSink) {
|
|
writeString(fileSink, "hello world", false);
|
|
});
|
|
|
|
try {
|
|
sink->createHardlink(CanonPath("foo-1.1/link"), CanonPath("hello"));
|
|
FAIL() << "Expected an exception";
|
|
} catch (const nix::Error & e) {
|
|
ASSERT_THAT(e.msg(), testing::HasSubstr("cannot find hard link target"));
|
|
ASSERT_THAT(e.msg(), testing::HasSubstr("/hello"));
|
|
ASSERT_THAT(e.msg(), testing::HasSubstr("foo-1.1/link"));
|
|
}
|
|
};
|
|
|
|
TEST_F(GitUtilsTest, peel_reference)
|
|
{
|
|
// Create a commit in the repo
|
|
git_repository * rawRepo = nullptr;
|
|
ASSERT_EQ(git_repository_open(&rawRepo, tmpDir.string().c_str()), 0);
|
|
|
|
// Create a blob
|
|
git_oid blob_oid;
|
|
const char * blob_content = "hello world";
|
|
ASSERT_EQ(git_blob_create_from_buffer(&blob_oid, rawRepo, blob_content, strlen(blob_content)), 0);
|
|
|
|
// Create a tree with that blob
|
|
git_treebuilder * builder = nullptr;
|
|
ASSERT_EQ(git_treebuilder_new(&builder, rawRepo, nullptr), 0);
|
|
ASSERT_EQ(git_treebuilder_insert(nullptr, builder, "file.txt", &blob_oid, GIT_FILEMODE_BLOB), 0);
|
|
|
|
git_oid tree_oid;
|
|
ASSERT_EQ(git_treebuilder_write(&tree_oid, builder), 0);
|
|
git_treebuilder_free(builder);
|
|
|
|
git_tree * tree = nullptr;
|
|
ASSERT_EQ(git_tree_lookup(&tree, rawRepo, &tree_oid), 0);
|
|
|
|
// Create a commit
|
|
git_signature * sig = nullptr;
|
|
ASSERT_EQ(git_signature_now(&sig, "nix", "nix@example.com"), 0);
|
|
|
|
git_oid commit_oid;
|
|
ASSERT_EQ(git_commit_create_v(&commit_oid, rawRepo, "HEAD", sig, sig, nullptr, "initial commit", tree, 0), 0);
|
|
|
|
// Lookup our commit
|
|
git_object * commit_object = nullptr;
|
|
ASSERT_EQ(git_object_lookup(&commit_object, rawRepo, &commit_oid, GIT_OBJECT_COMMIT), 0);
|
|
|
|
// Create annotated tag
|
|
git_oid tag_oid;
|
|
ASSERT_EQ(git_tag_create(&tag_oid, rawRepo, "v1", commit_object, sig, "annotated tag", 0), 0);
|
|
|
|
auto repo = openRepo();
|
|
|
|
// Use resolveRef to get peeled object
|
|
auto resolved = repo->resolveRef("refs/tags/v1");
|
|
|
|
// Now assert that we have unpeeled it!
|
|
ASSERT_STREQ(resolved.gitRev().c_str(), git_oid_tostr_s(&commit_oid));
|
|
|
|
git_signature_free(sig);
|
|
git_repository_free(rawRepo);
|
|
}
|
|
|
|
TEST(GitUtils, isLegalRefName)
|
|
{
|
|
ASSERT_TRUE(isLegalRefName("foox"));
|
|
ASSERT_TRUE(isLegalRefName("1337"));
|
|
ASSERT_TRUE(isLegalRefName("foo.baz"));
|
|
ASSERT_TRUE(isLegalRefName("foo/bar/baz"));
|
|
ASSERT_TRUE(isLegalRefName("foo./bar"));
|
|
ASSERT_TRUE(isLegalRefName("heads/foo@bar"));
|
|
ASSERT_TRUE(isLegalRefName("heads/fu\303\237"));
|
|
ASSERT_TRUE(isLegalRefName("foo-bar-baz"));
|
|
ASSERT_TRUE(isLegalRefName("branch#"));
|
|
ASSERT_TRUE(isLegalRefName("$1"));
|
|
ASSERT_TRUE(isLegalRefName("foo.locke"));
|
|
|
|
ASSERT_FALSE(isLegalRefName("refs///heads/foo"));
|
|
ASSERT_FALSE(isLegalRefName("heads/foo/"));
|
|
ASSERT_FALSE(isLegalRefName("///heads/foo"));
|
|
ASSERT_FALSE(isLegalRefName(".foo"));
|
|
ASSERT_FALSE(isLegalRefName("./foo"));
|
|
ASSERT_FALSE(isLegalRefName("./foo/bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo/./bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo/bar/."));
|
|
ASSERT_FALSE(isLegalRefName("foo bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo?bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo^bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo~bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo:bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo[bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo/bar/."));
|
|
ASSERT_FALSE(isLegalRefName(".refs/foo"));
|
|
ASSERT_FALSE(isLegalRefName("refs/heads/foo."));
|
|
ASSERT_FALSE(isLegalRefName("heads/foo..bar"));
|
|
ASSERT_FALSE(isLegalRefName("heads/foo?bar"));
|
|
ASSERT_FALSE(isLegalRefName("heads/foo.lock"));
|
|
ASSERT_FALSE(isLegalRefName("heads///foo.lock"));
|
|
ASSERT_FALSE(isLegalRefName("foo.lock/bar"));
|
|
ASSERT_FALSE(isLegalRefName("foo.lock///bar"));
|
|
ASSERT_FALSE(isLegalRefName("heads/v@{ation"));
|
|
ASSERT_FALSE(isLegalRefName("heads/foo\bar"));
|
|
|
|
ASSERT_FALSE(isLegalRefName("@"));
|
|
ASSERT_FALSE(isLegalRefName("\37"));
|
|
ASSERT_FALSE(isLegalRefName("\177"));
|
|
|
|
ASSERT_FALSE(isLegalRefName("foo/*"));
|
|
ASSERT_FALSE(isLegalRefName("*/foo"));
|
|
ASSERT_FALSE(isLegalRefName("foo/*/bar"));
|
|
ASSERT_FALSE(isLegalRefName("*"));
|
|
ASSERT_FALSE(isLegalRefName("foo/*/*"));
|
|
ASSERT_FALSE(isLegalRefName("*/foo/*"));
|
|
ASSERT_FALSE(isLegalRefName("/foo"));
|
|
ASSERT_FALSE(isLegalRefName(""));
|
|
}
|
|
|
|
} // namespace nix
|