nixos/rfcs
1
0
Fork 0
mirror of https://github.com/NixOS/rfcs.git synced 2025-12-21 08:21:20 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Small rephrasings

Browse source
This commit is contained in:
Doron Behar 2021-08-14 12:08:26 +03:00
parent c51c9c0561
commit 31a24a0348
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
rfcs/0075-declarative-wrappers.md
View file

@ -15,8 +15,8 @@ Manage the environment of wrappers declaratively and deprecate shell based
methods for calculating runtime environment of packages. Make it easier to methods for calculating runtime environment of packages. Make it easier to
debug why env vars are added to an executable, by storing this information debug why env vars are added to an executable, by storing this information
inside `/nix/store/.../nix-support/` of the dependencies that using them inside `/nix/store/.../nix-support/` of the dependencies that using them
requires require runtime environment. Create a new `makeWrapperAuto` hook that requires runtime environment. Create a new `makeWrapperAuto` hook that will
will make the `fixupPhase` read all of the deps environment that's needed and make the `fixupPhase` read all of the deps environment that's needed and
automatically wrap the executables with the proper environment. automatically wrap the executables with the proper environment.
# Motivation # Motivation
@ -232,8 +232,8 @@ order to work will get these environment variables set in the wrapper by
introduce a new `makeWrapperAuto` setup hook that will take care of this in the introduce a new `makeWrapperAuto` setup hook that will take care of this in the
way described as follows. way described as follows.
As a start, we'll need to think about all packages in Nixpkgs that using them As a start, we'll need to think about all packages in Nixpkgs that require
requires some environment variables to be set. Every such package will put in environment variables to be set at runtime. Every such package will put in
`$dev/nix-support/wrappers.json` a list of environment variables that are `$dev/nix-support/wrappers.json` a list of environment variables that are
"linked" to this package. "linked" means that using this package requires these "linked" to this package. "linked" means that using this package requires these
environment variables to be set in runtime. environment variables to be set in runtime.
@ -263,9 +263,10 @@ a given package:
``` ```
The information found inside an input's `wrappers.json` will specify the The information found inside an input's `wrappers.json` will specify the
wrapper information not only for itself, but for all its dependencies (including transitives) as well. Thus, in wrapper information not only for itself, but for all its dependencies
contrast to the [POC Nixpkgs PR](https://github.com/NixOS/nixpkgs/pull/85103) (including transitives) as well. Thus, in contrast to the [POC Nixpkgs
and the [original design of the PR](https://github.com/NixOS/nixpkgs/pull/85103) and the [original design of
the
RFC](https://github.com/doronbehar/rfcs/blob/60d3825fdd4e6574b7e5d70264445d1c801368c6/rfcs/0075-declarative-wrappers.md#L251), RFC](https://github.com/doronbehar/rfcs/blob/60d3825fdd4e6574b7e5d70264445d1c801368c6/rfcs/0075-declarative-wrappers.md#L251),
prior to [the 1st prior to [the 1st
meeting](https://github.com/NixOS/rfcs/pull/75#issuecomment-760942876), meeting](https://github.com/NixOS/rfcs/pull/75#issuecomment-760942876),