nixos/rfcs
1
0
Fork 0
mirror of https://github.com/NixOS/rfcs.git synced 2025-12-20 16:01:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Small rephrasings

Browse source
This commit is contained in:
Doron Behar 2021-03-19 12:46:24 +02:00
parent 034a13e50e
commit edbf315b98
1 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
rfcs/0075-declarative-wrappers.md
View file

@ -220,11 +220,11 @@ and get rid of these global environment variables.
[design]: #detailed-design [design]: #detailed-design
The end goal is to make the experience of getting a derivation wrapped as The end goal is to make the experience of getting a derivation wrapped as
automatic as possible. A derivation that needs a certain environment to run, automatic as possible. A derivation that needs some environment variables in
will put the dependency that is linked to this environment variable in order to work will get these environment variables set in the wrapper by
`envInputs` and `mkDerivation`'s standard `fixupPhase`. As a start, we'll (me `mkDerivation`'s standard `fixupPhase`. As a start, we'll (me probably) will
probably) will introduce a new `makeWrapperAuto` setup hook that will take care introduce a new `makeWrapperAuto` setup hook that will take care of this in the
in the way described as follows. way described as follows.
As a start, we'll need to think about all packages in Nixpkgs that using them As a start, we'll need to think about all packages in Nixpkgs that using them
requires some environment variables to be set. Every such package will put in requires some environment variables to be set. Every such package will put in
@ -264,20 +264,21 @@ RFC](https://github.com/doronbehar/rfcs/blob/60d3825fdd4e6574b7e5d70264445d1c801
prior to [the 1st prior to [the 1st
meeting](https://github.com/NixOS/rfcs/pull/75#issuecomment-760942876), meeting](https://github.com/NixOS/rfcs/pull/75#issuecomment-760942876),
traversing all the inputs and the inputs' inputs, will not happen during eval traversing all the inputs and the inputs' inputs, will not happen during eval
time and only partly, during build time - every package already built will be time and only partly, during build time - every package already built will
able to give another package all the information there needs to know about the provide it's reverse dependencies all the information they need about
related environment variables. environment variables of itself and of all of it's inputs and it's inputs'
inputs.
Most of the work to do will be: Most of the work to do will be:
1. Gather information about what environment variables are "linked" to each 1. Gather information about what environment variables are "linked" to each
package, and edit these derivations to include a `wrappers.json`, with package, and edit these derivations to include a `wrappers.json` in them.
`makeWrapperAuto`. This should be done with `makeWrapperAuto` as well, see (2).
2. Design the `makeWrapperAuto` shell hook: 2. Design the `makeWrapperAuto` shell hook:
- It should introduce a shell function (to be called `wrappersInfo`) that - It should introduce a shell function (to be called `wrappersInfo`) that
will allow piping a JSON string from `builtins.toJSON` and spit a will allow piping a JSON string from `builtins.toJSON` and spit a
`wrappers.json` that will include both what was piped into it, and the `wrappers.json` that will include both what was piped into it, and the
content from the package's inputs' `wrappers.json`. content from the package's various inputs' `wrappers.json` files.
- It should make the executables in `$out/bin/` get wrapped according to - It should make the executables in `$out/bin/` get wrapped according to
what's currently in this package's `wrappers.json`, during `fixupPhase`. what's currently in this package's `wrappers.json`, during `fixupPhase`.
- The above should be also possible to do manually for executables outside - The above should be also possible to do manually for executables outside
@ -330,7 +331,7 @@ while enable derivations to get rid of well known workarounds such as:
strictDeps = false; strictDeps = false;
``` ```
And: And often seen in Python + Qt programs:
```nix ```nix
preFixup = '' preFixup = ''