nvidia options update

modules/nixos/hardware/nvidia.nix

@@ -1,6 +1,6 @@
-{ lib, config, ... }:
+{ lib, config, pkgs, ... }:
 {
-  config = lib.mkIf config.osbmModules.hardware.nvidiaDriver.enable {
+  config = lib.mkIf config.osbmModules.hardware.nvidia.enable {
     # Enable OpenGL
     hardware.graphics = {
       enable = true;
@@ -10,21 +10,45 @@
     services.xserver.videoDrivers = [ "nvidia" ];
 
     hardware.nvidia = {
-      # Modesetting is required
+      # Modesetting is required.
       modesetting.enable = true;
 
-      # Nvidia power management
+      # Nvidia power management. Experimental, and can cause sleep/suspend to fail.
+      # Enable this if you have graphical corruption issues or application crashes after waking
+      # up from sleep. This fixes it by saving the entire VRAM memory to /tmp/ instead
+      # of just the bare essentials.
       powerManagement.enable = false;
+
+      # Fine-grained power management. Turns off GPU when not in use.
+      # Experimental and only works on modern Nvidia GPUs (Turing or newer).
       powerManagement.finegrained = false;
 
-      # Use the open source kernel module
+      # Use the NVidia open source kernel module (not to be confused with the
+      # independent third-party "nouveau" open source driver).
+      # Support is limited to the Turing and later architectures. Full list of
+      # supported GPUs is at:
+      # https://github.com/NVIDIA/open-gpu-kernel-modules#compatible-gpus
+      # Only available from driver 515.43.04+
+      # Currently alpha-quality/buggy, so false is currently the recommended setting.
       open = false;
 
-      # Enable the Nvidia settings menu
+      # Enable the Nvidia settings menu,
+      # accessible via `nvidia-settings`
       nvidiaSettings = true;
 
-      # Select appropriate driver version
-      package = config.boot.kernelPackages.nvidiaPackages.stable;
+      # Optionally, you may need to select the appropriate driver version for your specific GPU.
+      package = config.boot.kernelPackages.nvidiaPackages.latest;
+    };
+
+    environment.systemPackages = [
+      pkgs.nvidia-container-toolkit
+    ];
+
+
+    # TODO explain why this is needed
+    programs.nix-required-mounts = {
+      enable = true;
+      presets.nvidia-gpu.enable = true;
     };
 
     # Enable nvidia-container-toolkit if virtualization is enabled

modules/nixos/options.nix

@@ -175,7 +175,7 @@
         };
       };
 
-      nvidiaDriver = {
+      nvidia = {
         enable = lib.mkOption {
           type = lib.types.bool;
           default = false;