nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-08 19:46:02 +01:00
Code Activity

shellcheck fix: tests/functional/nix-build.sh

Browse source
This commit is contained in:
Farid Zakaria 2025-09-29 09:46:43 -07:00
parent 794723142b
commit 2bfc9019fa
2 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
maintainers/flake-module.nix
View file

@ -106,7 +106,6 @@
enable = true; enable = true;
excludes = [ excludes = [
# We haven't linted these files yet # We haven't linted these files yet
''^tests/functional/nix-build\.sh$''
''^tests/functional/nix-channel\.sh$'' ''^tests/functional/nix-channel\.sh$''
''^tests/functional/nix-collect-garbage-d\.sh$'' ''^tests/functional/nix-collect-garbage-d\.sh$''
''^tests/functional/nix-copy-ssh-common\.sh$'' ''^tests/functional/nix-copy-ssh-common\.sh$''

28
tests/functional/nix-build.sh
View file

@ -6,30 +6,30 @@ TODO_NixOS
clearStoreIfPossible clearStoreIfPossible
outPath=$(nix-build dependencies.nix -o $TEST_ROOT/result) outPath=$(nix-build dependencies.nix -o "$TEST_ROOT"/result)
test "$(cat $TEST_ROOT/result/foobar)" = FOOBAR test "$(cat "$TEST_ROOT"/result/foobar)" = FOOBAR
# The result should be retained by a GC. # The result should be retained by a GC.
echo A echo A
target=$(readLink $TEST_ROOT/result) target=$(readLink "$TEST_ROOT"/result)
echo B echo B
echo target is $target echo target is "$target"
nix-store --gc nix-store --gc
test -e $target/foobar test -e "$target"/foobar
# But now it should be gone. # But now it should be gone.
rm $TEST_ROOT/result rm "$TEST_ROOT"/result
nix-store --gc nix-store --gc
if test -e $target/foobar; then false; fi if test -e "$target"/foobar; then false; fi
outPath2=$(nix-build $(nix-instantiate dependencies.nix) --no-out-link) outPath2=$(nix-build "$(nix-instantiate dependencies.nix)" --no-out-link)
[[ $outPath = $outPath2 ]] [[ $outPath = "$outPath2" ]]
outPath2=$(nix-build $(nix-instantiate dependencies.nix)!out --no-out-link) outPath2=$(nix-build "$(nix-instantiate dependencies.nix)"!out --no-out-link)
[[ $outPath = $outPath2 ]] [[ $outPath = "$outPath2" ]]
outPath2=$(nix-store -r $(nix-instantiate --add-root $TEST_ROOT/indirect dependencies.nix)!out) outPath2=$(nix-store -r "$(nix-instantiate --add-root "$TEST_ROOT"/indirect dependencies.nix)"!out)
[[ $outPath = $outPath2 ]] [[ $outPath = "$outPath2" ]]
# The order of the paths on stdout must correspond to the -A options # The order of the paths on stdout must correspond to the -A options
# https://github.com/NixOS/nix/issues/4197 # https://github.com/NixOS/nix/issues/4197
@ -39,9 +39,11 @@ input1="$(nix-build nix-build-examples.nix -A input1 --no-out-link)"
input2="$(nix-build nix-build-examples.nix -A input2 --no-out-link)" input2="$(nix-build nix-build-examples.nix -A input2 --no-out-link)"
body="$(nix-build nix-build-examples.nix -A body --no-out-link)" body="$(nix-build nix-build-examples.nix -A body --no-out-link)"
# shellcheck disable=SC2046,SC2005
outPathsA="$(echo $(nix-build nix-build-examples.nix -A input0 -A input1 -A input2 -A body --no-out-link))" outPathsA="$(echo $(nix-build nix-build-examples.nix -A input0 -A input1 -A input2 -A body --no-out-link))"
[[ "$outPathsA" = "$input0 $input1 $input2 $body" ]] [[ "$outPathsA" = "$input0 $input1 $input2 $body" ]]
# test a different ordering to make sure it fails, not just in 23 out of 24 permutations # test a different ordering to make sure it fails, not just in 23 out of 24 permutations
# shellcheck disable=SC2046,SC2005
outPathsB="$(echo $(nix-build nix-build-examples.nix -A body -A input1 -A input2 -A input0 --no-out-link))" outPathsB="$(echo $(nix-build nix-build-examples.nix -A body -A input1 -A input2 -A input0 --no-out-link))"
[[ "$outPathsB" = "$body $input1 $input2 $input0" ]] [[ "$outPathsB" = "$body $input1 $input2 $input0" ]]