nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-08 19:46:02 +01:00
Code Activity
21732 commits 177 branches 218 tags 162 MiB
Commit graph

21732 commits

This branch
This branch
All branches
Author SHA1 Message Date
Henry
6985e9f2c3
fix(libstore): Rewrite hard linking message to be more clear 2025-10-30 03:05:06 -05:00
John Ericson
e6f0dd8df5
Merge pull request #14420 from lovesegfault/compressed-source 
refactor(libutil): add `CompressedSource`
 2025-10-30 05:21:41 +00:00
Bernardo Meurer Costa
93fe3354b5
refactor(libutil): add CompressedSource 
Introduce a `CompressedSource` class in libutil's `serialise.hh` that
compresses a `RestartableSource` and owns the compressed data. This is a
general-purpose utility that can be used anywhere compressed data needs
to be treated as a source.
 2025-10-30 04:35:27 +00:00
John Ericson
bffbdcfddc
Merge pull request #14390 from NixOS/constant-memory-uploads 
libstore: Make HTTP binary cache uploads run in constant memory
 2025-10-29 23:14:42 +00:00
John Ericson
495d1b8435
Merge pull request #14393 from lovesegfault/s3-multipart-tests 
test(nixos): add S3 multipart upload integration tests
 2025-10-29 22:56:21 +00:00
John Ericson
66d7b8fe1b
Merge pull request #14396 from roberth/c-api-docs 
doc: Improve libexpr-c docs
 2025-10-29 22:38:04 +00:00
Sergei Zimmerman
cf75079bd8 libstore: Make uploads with filetransfer.cc consume a RestartableSource 
Make uploads run in constant memory. Also change the callbacks to be
noexcept, since we really don't want to be unwinding the stack in the
curl thread. That will definitely corrupt that stack and make nix/curl
crash in very bad ways.
 2025-10-29 18:34:56 -04:00
Sergei Zimmerman
b8d7f551e4 libutil: Add RestartableSource 
This is necessary to make seeking work with libcurl.
 2025-10-29 18:25:49 -04:00
Sergei Zimmerman
e947c895ec binary-cache-store: UpsertFile accept Source & instead of std::istream 2025-10-29 18:25:49 -04:00
Robert Hensing
f301669adc
doc/dev/documentation: Use appendToVar 
Co-authored-by: John Ericson <git@JohnEricson.me>
 2025-10-29 22:53:43 +01:00
John Ericson
e3c41407f9
Merge pull request #14391 from lovesegfault/nix-s3-complete-multipart 
feat(libstore/s3-binary-cache-store): implement `completeMultipartUpload()`
 2025-10-29 20:49:12 +00:00
John Ericson
00f4a860e7
Merge pull request #14400 from obsidiansystems/json-schema-derivation-output 
Enable JSON schema testing for derivation outputs
 2025-10-29 19:40:29 +00:00
Sergei Zimmerman
da637a05da
Merge pull request #14410 from bryango/patch-1 
zsh/completion: put compdef on first line
 2025-10-29 15:24:02 +00:00
bryango
956fffdd6f
zsh/completion: put compdef on first line 
Some zsh setups (including mine) do not load the
completion if `#compdef` is not on the first line.

So we move the `# shellcheck` comment to the
second line to avoid this issue.
 2025-10-29 18:09:42 +08:00
John Ericson
bac41d6989
Merge pull request #14289 from obsidiansystems/fix-14287 
Fix issue #14287
 2025-10-29 07:17:59 +00:00
John Ericson
de192794c9 Fix issue #14287 
The test added in the previous commit now passes.

Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
 2025-10-29 02:15:46 -04:00
John Ericson
246dbe1c05 Regression test for issue #14287 
This will currently fail, until the bug is fixed.

Co-Authored-By: Sergei Zimmerman <sergei@zimmerman.foo>
 2025-10-29 02:15:41 -04:00
Sergei Zimmerman
194c21fc82
Merge pull request #14407 from NixOS/fix-upload-put-http 
libstore/filetransfer: Add HttpMethod::PUT
 2025-10-29 03:24:10 +00:00
Sergei Zimmerman
e08853a67c
Merge pull request #14406 from NixOS/better-error-message 
libstore/http-binary-cache-store: Improve error messages in HttpBinar…
 2025-10-29 03:23:49 +00:00
Sergei Zimmerman
ae49074548
libstore/filetransfer: Add HttpMethod::PUT 
This got lost in f1968ea38e and
now we had incorrect logs that confused "downloading" when we were
in fact "uploading" things.
 2025-10-29 02:48:26 +03:00
Sergei Zimmerman
f1d4fab1e5
Merge pull request #14405 from obsidiansystems/json-schema-store-path 
Create JSON Schema for Store Paths
 2025-10-28 23:24:05 +00:00
Sergei Zimmerman
c874e7071b
libstore/http-binary-cache-store: Improve error messages in HttpBinaryCacheStore::upsertFile 
Now the error message doesn't cram everything into a single line and we now instead get:

error:
       … while uploading to HTTP binary cache at 's3://my-cache?endpoint=http://localhost:9000?compression%3Dzstd&region=eu-west-1'

       error: unable to download 'http://localhost:9000/my-cache/nar/1125zqba8cx8wbfa632vy458a3j3xja0qpcqafsfdildyl9dqa7x.nar.xz': Operation was aborted by an application callback (42)
 2025-10-29 02:05:14 +03:00
John Ericson
c67966418f Create JSON Schema for Store Paths 
We immediately use this in the JSON schemas for Derivation and Deriving
Path, but we cannot yet use it in Store Object Info because those paths
*do* include the store dir currently.
 2025-10-28 17:22:51 -04:00
John Ericson
be2572ed8d Make inputDrvs JSON schema more precise 
It now captures the stable non-recursive format (just an output set) and
the unstable recursive form for dynamic derivations.
 2025-10-28 17:22:30 -04:00
Sergei Zimmerman
be99a1c6bb
Merge pull request #14404 from Mic92/test-settings 
coderabbit: disable high_level_summary/poem/github status
 2025-10-28 21:10:56 +00:00
Jörg Thalheim
fe8cdbc3e4 coderabbit: disable high_level_summary/poem/github status/sequence_diagrams 2025-10-28 22:09:05 +01:00
Sergei Zimmerman
70176ed317
Merge pull request #14402 from Mic92/test-settings 
coderabbit: don't show review status
 2025-10-28 20:46:31 +00:00
Jörg Thalheim
84a5bee424 coderabbit: disable reporting review status 2025-10-28 21:45:30 +01:00
John Ericson
e3246301a6 Enable JSON schema testing for derivation outputs 
I figured out what the problem was: the fragment needs to start with a
`/`.
 2025-10-28 16:07:44 -04:00
Sergei Zimmerman
d4c69c7b8f
Merge pull request #14398 from roberth/quiet-coderabbit 2025-10-28 18:41:43 +00:00
Robert Hensing
f5aafbd6ed .coderabbit.yaml: Disable auto-review 2025-10-28 19:39:04 +01:00
Robert Hensing
5fc0c4f102 doc: Improve libexpr-c docs 
- Uses the more explicit `@ingroup` most of the time, to avoid problems
  with nested groups, and to make group membership more explicit.
  The division into headers is not great for documentation purposes,
  so this helps.
- More attention for memory management details
- Various other improvements to doc comments
 2025-10-28 17:57:15 +01:00
Eelco Dolstra
1a4ad0706b
Merge pull request #14394 from me-and/no-print-dead-space-usage 
docs: remove incorrect claim re gc --print-dead
 2025-10-28 15:10:54 +00:00
Adam Dinwoodie
972915cabd docs: remove incorrect claim re gc --print-dead 
Per #7591, the `nix-store --gc --print-dead` command does not provide
any feedback about the amount of disk space that is used by dead store
paths.  It looks like this has been the case since 7ab68961e (* Garbage
collector: added an option `--use-atime' to delete paths in...,
2008-09-17).

Update the nix-store documentation to remove the claim that this is
function that `nix-store --gc --print-dead` performs.
 2025-10-28 09:47:25 +00:00
Bernardo Meurer Costa
94965a3a3e
test(nixos): add S3 multipart upload integration tests 2025-10-28 06:17:41 +00:00
Bernardo Meurer Costa
c77317b1a9
feat(libstore/s3-binary-cache-store): implement completeMultipartUpload() 
`completeMultipartUpload()`: Build XML with part numbers and `ETags`,
POST to key with `?uploadId` to finalize the multipart upload
 2025-10-28 01:13:28 +00:00
Jörg Thalheim
dd0d006517
Merge pull request #14375 from lovesegfault/nix-s3-upload-part 
feat(libstore/s3-binary-cache-store): implement `uploadPart()`
 2025-10-27 22:40:00 +00:00
John Ericson
1d3f0ca22e
Merge pull request #14383 from obsidiansystems/misc-cleanups 
Two misc cleanups
 2025-10-27 22:16:37 +00:00
Bernardo Meurer Costa
c592090fff
feat(libstore/s3-binary-cache-store): implement uploadPart() 
Implement `uploadPart()` for uploading individual parts in S3 multipart
uploads:

- Constructs URL with `?partNumber=N&uploadId=ID` query parameters
- Uploads chunk data with `application/octet-stream` mime type
- Extracts and returns `ETag` from response
 2025-10-27 21:09:39 +00:00
Bernardo Meurer Costa
4b6d07d642
feat(libstore/s3-binary-cache-store): implement createMultipartUpload() 
POST to key with `?uploads` query parameter, optionally set
`Content-Encoding` header, parse `uploadId` from XML response using
regex
 2025-10-27 21:07:29 +00:00
John Ericson
e177f42536
Merge pull request #14379 from Radvendii/exprlist-alloc 
libexpr: store ExprList data in Exprs::alloc
 2025-10-27 21:04:45 +00:00
John Ericson
ac8b1efcf9
Merge pull request #14379 from Radvendii/exprlist-alloc 
libexpr: store ExprList data in Exprs::alloc
 2025-10-27 21:04:45 +00:00
John Ericson
aa4106fd68
Merge pull request #14360 from lovesegfault/scan-for-references-detailed 
feat(libstore): add scanForReferencesDeep and use it for why-depends
 2025-10-27 20:38:10 +00:00
John Ericson
7f1d92793e
Merge pull request #14360 from lovesegfault/scan-for-references-detailed 
feat(libstore): add scanForReferencesDeep and use it for why-depends
 2025-10-27 20:38:10 +00:00
John Ericson
234f029940 Add consuming ref <-> std::share_ptr methods/ctrs 
This can help churning ref counts when we don't need to.
 2025-10-27 16:23:43 -04:00
John Ericson
dd716dc9be Create default Store::narFromPath implementation in terms of getFSAccessor 
This is a good default (the methods that allow for an arbitrary choice
of source accessor are generally preferable both to implement and to
use). And it also pays its way by allowing us to delete *both* the
`DummyStore` and `LocalStore` implementations.
 2025-10-27 15:57:26 -04:00
John Ericson
ea17cc1b57
Merge pull request #14376 from lovesegfault/nix-s3-abort-multipart 
feat(libstore/s3-binary-cache-store): implement `abortMultipartUpload()`
 2025-10-27 19:52:36 +00:00
John Ericson
0c1be3aabe
Merge pull request #14309 from obsidiansystems/json-schema-content-address 
` nlohmann::json` instance and JSON Schema for `ContentAddress`
 2025-10-27 19:52:19 +00:00
John Ericson
1c41e07b46
Merge pull request #14385 from lovesegfault/ci-concurrency-group 
ci: cancel previous workflow runs on PR updates
 2025-10-27 17:35:50 -04:00
Bernardo Meurer Costa
ad664ce64e
ci: cancel previous workflow runs on PR updates 
Add concurrency group configuration to the CI workflow to automatically
cancel outdated runs when a PR receives new commits or is force-pushed.
This prevents wasting CI resources on superseded code.
 2025-10-27 20:56:56 +00:00