Farid Zakaria
f394390492
shellcheck fix: tests/functional/local-overlay-store/add-lower-inner.sh
2025-09-28 20:40:08 -07:00
Farid Zakaria
8f0d9412ba
shellcheck fix: tests/functional/local-overlay-store/bad-uris.sh
2025-09-28 20:39:40 -07:00
Farid Zakaria
8f14301533
shellcheck fix: tests/functional/local-overlay-store/build-inner.sh
2025-09-28 20:38:46 -07:00
Farid Zakaria
6cae8da29d
shellcheck fix: tests/functional/local-overlay-store/check-post-init.sh
2025-09-28 20:37:23 -07:00
Farid Zakaria
bb97f4b07a
shellcheck fix: tests/functional/local-overlay-store/common.sh
2025-09-28 20:35:47 -07:00
Farid Zakaria
20665e1c3d
shellcheck fix: tests/functional/local-overlay-store/delete-duplicate-inner.sh
2025-09-28 20:32:49 -07:00
Farid Zakaria
326d626ad7
shellcheck fix: tests/functional/local-overlay-store/delete-refs-inner.sh
2025-09-28 20:32:12 -07:00
Farid Zakaria
62b36eba11
shellcheck fix: tests/functional/local-overlay-store/gc-inner.sh
2025-09-28 20:31:09 -07:00
Farid Zakaria
675179a510
shellcheck fix: tests/functional/local-overlay-store/gc.sh
2025-09-28 20:30:02 -07:00
Farid Zakaria
283a9c4c5a
shellcheck fix: tests/functional/local-overlay-store/optimise-inner.sh
2025-09-28 20:29:35 -07:00
Farid Zakaria
dbb53de9d3
shellcheck fix: tests/functional/local-overlay-store/redundant-add.sh
2025-09-28 20:28:18 -07:00
Farid Zakaria
0c50d5b25a
shellcheck fix: tests/functional/local-overlay-store/redundant-add-inner.sh
2025-09-28 20:27:21 -07:00
Farid Zakaria
1bee4d0988
shellcheck fix: tests/functional/local-overlay-store/redundant-add.sh
2025-09-28 20:25:42 -07:00
Farid Zakaria
4ef4e96788
shellcheck fix: tests/functional/local-overlay-store/remount.sh
2025-09-28 20:25:09 -07:00
Farid Zakaria
c4c95f3d39
shellcheck fix: tests/functional/local-overlay-store/stale-file-handle-inner.sh
2025-09-28 20:24:38 -07:00
Farid Zakaria
e896bf1cb1
shellcheck fix: tests/functional/local-overlay-store/stale-file-handle.sh
2025-09-28 20:24:09 -07:00
Farid Zakaria
3a1ba8e41e
shellcheck fix: tests/functional/local-overlay-store/verify-inner.sh
2025-09-28 20:23:19 -07:00
Farid Zakaria
76c9d3885c
shellcheck fix: tests/functional/local-overlay-store/verify.sh
2025-09-28 20:22:55 -07:00
John Ericson
676e885f8d
Merge pull request #14084 from obsidiansystems/issue-13247-test
...
Create test for Issue 13247
2025-09-28 19:12:44 -04:00
John Ericson
241c7cd1f9
Merge pull request #14104 from xokdvium/dead-code-location
...
libexpr: Remove unused members from ParserLocation
2025-09-28 16:46:50 -04:00
Sergei Zimmerman
0f08feaa58
libexpr: Remove unused members from ParserLocation
2025-09-28 22:57:11 +03:00
Sergei Zimmerman
c43ea09b9b
Merge pull request #14100 from obsidiansystems/add-missing-pragma-once
...
Add `#pragma once` to `dummy-store.hh`
2025-09-28 16:41:28 +00:00
John Ericson
582d3ee611
Add #pragma once to dummy-store.hh
...
We should have a lint for this.
In later (yet to be merged at this time) commits, this started causing
problems that only the sanitzer caught.
2025-09-28 12:12:24 -04:00
John Ericson
f7d35dc1dc
Merge pull request #14099 from xokdvium/fix-assert-failure
...
libstore: Call canonPath for constructing LocalFSStoreConfig::rootDir
2025-09-28 12:06:02 -04:00
Sergei Zimmerman
0866ba0b4a
libstore: Deduplicate LocalFSStoreConfig::rootDir initializers
...
Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
2025-09-28 18:38:57 +03:00
John Ericson
a01d52e57b
Merge pull request #14063 from obsidiansystems/test-less-macro
...
Minimize the use of C Macros for characterization tests
2025-09-28 11:14:29 -04:00
John Ericson
87fc579bb7
Merge pull request #14098 from xokdvium/store-references-fixes
...
libstore: Make all StoreConfig::getReference implementations return s…
2025-09-28 11:11:49 -04:00
Sergei Zimmerman
3a64d3c0da
libstore: Call canonPath for constructing LocalFSStoreConfig::rootDir
...
This mirrors what OptionalPathSetting does. Otherwise we run into
an assertion failure for relative paths specified as the authority + path:
nix build nixpkgs#hello --store "local://a/b"
nix: ../posix-source-accessor.cc:13: nix::PosixSourceAccessor::PosixSourceAccessor(std::filesystem::__cxx11::path&&): Assertion `root.empty() || root.is_absolute()' failed.
This is now diagnosed properly:
error: not an absolute path: 'a/b'
Just as you'd specify the root via a query parameter:
nix build nixpkgs#hello --store "local?root=a/b"
2025-09-28 17:42:19 +03:00
John Ericson
01b2037bc0
Minimize the use of C Macros for characterization tests
...
Fewer macros is better!
Introduce a new `JsonChacterizationTest` mixin class to help with this.
Also, avoid some needless copies with `GetParam`.
Part of my effort shoring up the JSON formats with #13570 .
2025-09-28 09:54:46 -04:00
Sergei Zimmerman
426a72c9cf
libstore: Make all StoreConfig::getReference implementations return store parameters
...
These stragglers have been accidentally left out when implementing the StoreConfig::getReference.
Also HttpBinaryCacheStore::getReference now returns the actual store parameters, not the cacheUri
parameters.
2025-09-28 16:29:12 +03:00
John Ericson
e35abb1102
Create test for issue 13247
...
This test ends up being skipped, since the bug has not yet been fixed. A
future commit will fix the bug.
Progress on #13247 , naturally.
2025-09-27 21:53:14 -04:00
John Ericson
3c610df550
Delete scratch data for CA derivation that produced already-extant output
...
In the case where the store object doesn't exist, we do correctly move
(rather than copy) the scratch data into place. In this case, the
destination store object already exists, but we still want to clean up
after ourselves.
2025-09-27 15:14:33 -04:00
John Ericson
3bf1268ac6
Merge pull request #14096 from Mic92/concurrency-bugs-2
...
document thread-unsafe mutation in PosixSourceAccessor
2025-09-27 11:18:56 -04:00
Sergei Zimmerman
b9571b6e52
Merge pull request #13508 from CertainLach/push-oyyysvytlnpr
...
fix: wait on incomplete assignment in REPL
2025-09-27 10:43:41 +00:00
Yaroslav Bolyukin
0a3eb22360
fix: wait on incomplete assignment in REPL
...
Fixes: https://github.com/NixOS/nix/issues/13507
2025-09-27 13:25:27 +03:00
Jörg Thalheim
866c9179a0
document thread-unsafe mutation in PosixSourceAccessor
2025-09-26 23:31:56 +02:00
Jörg Thalheim
7817239644
Merge pull request #14092 from rszyma/fix-devshell-attrpath-in-docs
...
doc: Fix invalid devshell attrpath
2025-09-26 21:01:02 +02:00
Jörg Thalheim
be92b18add
Merge pull request #14083 from fzakaria/fzakaria/shellcheck-multiple-2
...
shellcheck fixes
2025-09-26 20:42:43 +02:00
rszyma
7bd67cd8dc
doc: Fix invalid devshell attrpath
...
`native-clangStdenvPackages` devshell attrpath was being mentioned in
development docs, but doesn't work anymore (since 69fde530
2025-09-26 19:49:36 +02:00
Jörg Thalheim
b5f765b7eb
Merge pull request #14047 from Radvendii/eval-memory
...
libexpr: move eval memory allocation to own struct
2025-09-26 19:24:30 +02:00
Farid Zakaria
2a6724299a
shellcheck fix: tests/functional/flakes/follow-paths.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
6fc8f04ecb
shellcheck fix: tests/functional/flakes/flakes.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
ac5615dd91
shellcheck fix: tests/functional/flakes/config.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
26a10453c3
shellcheck fix: tests/functional/flakes/check.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
9bf8e7b730
shellcheck fix: tests/functional/flakes/absolute-paths.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
8839bab84d
shellcheck fix: completion files
2025-09-26 08:41:30 -07:00
Farid Zakaria
f8e351cd94
shellcheck fix: tests/functional/fixed
2025-09-26 08:41:30 -07:00
Farid Zakaria
4cec876319
shellcheck fix: tests/functional/fetchMercurial.sh
2025-09-26 08:41:30 -07:00
Farid Zakaria
c4c3524318
shellcheck fix: tests/functional/fetchGitVerification.sh
2025-09-26 08:41:29 -07:00
Eelco Dolstra
8aa4669328
Merge pull request #14086 from getchoo-contrib/getchoo/help-pure-eval
...
nix-cli: use pure/restricted eval for help pages
2025-09-26 11:32:14 +02:00
